[ https://issues.apache.org/jira/browse/BEAM-7970?focusedWorklogId=360622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360622 ]
ASF GitHub Bot logged work on BEAM-7970: ---------------------------------------- Author: ASF GitHub Bot Created on: 17/Dec/19 00:22 Start Date: 17/Dec/19 00:22 Worklog Time Spent: 10m Work Description: youngoli commented on pull request #10393: [BEAM-7970] Rebuild Go protos with new protobuf version URL: https://github.com/apache/beam/pull/10393 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 360622) Time Spent: 2h 40m (was: 2.5h) > Regenerate Go SDK proto files in correct version > ------------------------------------------------ > > Key: BEAM-7970 > URL: https://issues.apache.org/jira/browse/BEAM-7970 > Project: Beam > Issue Type: Bug > Components: sdk-go > Reporter: Daniel Oliveira > Assignee: Daniel Oliveira > Priority: Major > Fix For: Not applicable > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Generated proto files in the Go SDK currently include this bit: > {{// This is a compile-time assertion to ensure that this generated file}} > {{// is compatible with the proto package it is being compiled against.}} > {{// A compilation error at this line likely means your copy of the}} > {{// proto package needs to be updated.}} > {{const _ = proto.ProtoPackageIsVersion2 // please upgrade the proto package}} > > This indicates that the protos are being generated as proto v2 for whatever > reason. Most likely, as mentioned by this post with someone with a similar > issue, because the proto generation binary needs to be rebuilt before > generating the files again: > [https://github.com/golang/protobuf/issues/449#issuecomment-340884839] > This hasn't caused any errors so far, but might eventually cause errors if we > hit version differences between the v2 and v3 protos. -- This message was sent by Atlassian Jira (v8.3.4#803005)