[
https://issues.apache.org/jira/browse/BEAM-8630?focusedWorklogId=360998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360998
]
ASF GitHub Bot logged work on BEAM-8630:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/19 17:34
Start Date: 17/Dec/19 17:34
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #9913: [BEAM-8630]
Prototype of BeamZetaSqlCalcRel
URL: https://github.com/apache/beam/pull/9913#discussion_r358926652
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRuleSets.java
##########
@@ -159,14 +158,42 @@
BeamCoGBKJoinRule.INSTANCE,
BeamSideInputLookupJoinRule.INSTANCE);
+ private static final List<RelOptRule> BEAM_CONVERTERS_CALCITE_SQL_ONLY =
+ ImmutableList.of(BeamCalcRule.INSTANCE);
+
private static final List<RelOptRule> BEAM_TO_ENUMERABLE =
ImmutableList.of(BeamEnumerableConverterRule.INSTANCE);
public static RuleSet[] getRuleSets() {
return new RuleSet[] {
RuleSets.ofList(
ImmutableList.<RelOptRule>builder()
- .addAll(BEAM_CONVERTERS)
+ .addAll(BEAM_CONVERTERS_COMMON)
+ .addAll(BEAM_CONVERTERS_CALCITE_SQL_ONLY)
+ .addAll(BEAM_TO_ENUMERABLE)
+ .addAll(LOGICAL_OPTIMIZATIONS)
+ .build())
+ };
+ }
+
+ /** Returns the rule sets that allow using ZetaSQL evaluator for Calc. */
Review comment:
All the changes in this file should be reverted. `BeamCalcRule` can be
replaced with `BeamZetaSqlCalcRule` in `ZetaSQLQueryPlanner`.
https://github.com/apache/beam/blob/4875f4576f6d17ba331ab386d583d99ab4ce1a2d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java#L123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 360998)
Remaining Estimate: 0h
Time Spent: 10m
> Prototype of BeamSQL Calc using ZetaSQL Expression Evaluator
> ------------------------------------------------------------
>
> Key: BEAM-8630
> URL: https://issues.apache.org/jira/browse/BEAM-8630
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
