[ 
https://issues.apache.org/jira/browse/BEAM-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000402#comment-17000402
 ] 

Tomo Suzuki edited comment on BEAM-8695 at 12/19/19 9:25 PM:
-------------------------------------------------------------

Failures on 
{{org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest}} 
seems to be related to handling equality with maps.

 !LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders.png! 

The assertion fails because the actual is HashMap and {{GenericData.equals}} 
checks other object's class in google-http-client 1.34.0:

{code:java}
// GenericData equals
...
    if (o == null || !(o instanceof GenericData)) {
      return false;
    }
{code}




was (Author: suztomo):
Failures on 
{{org.apache.beam.runners.dataflow.worker.graph.LengthPrefixUnknownCodersTest}} 
seems to be related to handling equality with maps.

 !LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders.png! 

> Beam Dependency Update Request: com.google.http-client:google-http-client
> -------------------------------------------------------------------------
>
>                 Key: BEAM-8695
>                 URL: https://issues.apache.org/jira/browse/BEAM-8695
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dependencies
>            Reporter: Beam JIRA Bot
>            Priority: Major
>         Attachments: 
> LengthPrefixUnknownCodersTest.testLengthPrefixUnknownCoders.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
>  ------------------------- 2019-11-15 19:40:13.570557 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.http-client:google-http-client. 
>         The current version is 1.28.0. The latest version is 1.33.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-11-19 21:06:20.477284 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.http-client:google-http-client. 
>         The current version is 1.28.0. The latest version is 1.33.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-12-02 12:12:12.146269 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.http-client:google-http-client. 
>         The current version is 1.28.0. The latest version is 1.33.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 
>  ------------------------- 2019-12-09 12:11:24.693912 
> -------------------------
>         Please consider upgrading the dependency 
> com.google.http-client:google-http-client. 
>         The current version is 1.28.0. The latest version is 1.33.0 
>         cc: 
>  Please refer to [Beam Dependency Guide 
> |https://beam.apache.org/contribute/dependencies/]for more information. 
> Do Not Modify The Description Above. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to