[ https://issues.apache.org/jira/browse/BEAM-8630?focusedWorklogId=361909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361909 ]
ASF GitHub Bot logged work on BEAM-8630: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Dec/19 22:20 Start Date: 20/Dec/19 22:20 Worklog Time Spent: 10m Work Description: apilloud commented on pull request #9913: [BEAM-8630] Prototype of BeamZetaSqlCalcRel URL: https://github.com/apache/beam/pull/9913#discussion_r360587972 ########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/WithLimitableInput.java ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.extensions.sql.impl.rel; + +import org.apache.beam.sdk.annotations.Internal; + +/** Interface for a {@code Calc} whose input can be a {@link BeamSortRel} with a limit count. */ +@Internal +public interface WithLimitableInput { Review comment: nit: The implementation of this interface is identical between here and BeamCalcRel. What you actually have is a common class `BeamCalc` on top of calcite's `core.Calc`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 361909) Time Spent: 1h 10m (was: 1h) > Prototype of BeamSQL Calc using ZetaSQL Expression Evaluator > ------------------------------------------------------------ > > Key: BEAM-8630 > URL: https://issues.apache.org/jira/browse/BEAM-8630 > Project: Beam > Issue Type: New Feature > Components: dsl-sql > Reporter: Yueyang Qiu > Assignee: Yueyang Qiu > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)