[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=362213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362213
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/19 00:25
Start Date: 22/Dec/19 00:25
Worklog Time Spent: 10m
Work Description: y1chi commented on pull request #10447: [BEAM-8575]
Refactor test_do_fn_with_windowing_in_finish_bundle to work with Dataflow runner
URL: https://github.com/apache/beam/pull/10447#discussion_r360674623
##########
File path: sdks/python/apache_beam/transforms/ptransform_test.py
##########
@@ -347,14 +347,14 @@ def finish_bundle(self):
pipeline = TestPipeline()
result = (pipeline
- | 'Start' >> beam.Create([x for x in range(3)])
+ | 'Start' >> beam.Create([1])
| beam.ParDo(MyDoFn())
| WindowInto(windowfn)
| 'create tuple' >> beam.Map(
lambda v, t=beam.DoFn.TimestampParam,
w=beam.DoFn.WindowParam:
(v, t, w.start, w.end)))
- expected_process = [('process'+ str(x), Timestamp(5), Timestamp(4),
- Timestamp(6)) for x in range(3)]
+ expected_process = [('process'+ str(1), Timestamp(5), Timestamp(4),
Review comment:
```suggestion
expected_process = [('process1', Timestamp(5), Timestamp(4),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 362213)
Time Spent: 38h 40m (was: 38.5h)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 38h 40m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
