[ https://issues.apache.org/jira/browse/BEAM-9037?focusedWorklogId=365024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365024 ]
ASF GitHub Bot logged work on BEAM-9037: ---------------------------------------- Author: ASF GitHub Bot Created on: 31/Dec/19 16:23 Start Date: 31/Dec/19 16:23 Worklog Time Spent: 10m Work Description: alexvanboxel commented on issue #10486: [BEAM-9037] Instant and duration as logical type URL: https://github.com/apache/beam/pull/10486#issuecomment-569953631 @TheNeuralBit @reuvenlax this PR promotes the Timestamp+Duration to NanosInstant and NanosDuration. Please see the PR for more information and reference to the design document. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 365024) Time Spent: 20m (was: 10m) > Instant and duration as logical type > ------------------------------------- > > Key: BEAM-9037 > URL: https://issues.apache.org/jira/browse/BEAM-9037 > Project: Beam > Issue Type: Task > Components: sdk-java-core > Reporter: Alex Van Boxel > Assignee: Alex Van Boxel > Priority: Major > Fix For: 2.19.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The proto schema includes Timestamp and Duration with nano precision. The > logical types should be promoted to the core logical types, so they can be > handled on various IO's as standard mandatory conversions. > This means that the logical type should use the proto specific Timestamp and > Duration but the java 8 Instant and Duration. > See discussion in the design document: > [https://docs.google.com/document/d/1uu9pJktzT_O3DxGd1-Q2op4nRk4HekIZbzi-0oTAips/edit#heading=h.9uhml95iygqr] -- This message was sent by Atlassian Jira (v8.3.4#803005)