[
https://issues.apache.org/jira/browse/BEAM-6857?focusedWorklogId=366227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366227
]
ASF GitHub Bot logged work on BEAM-6857:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/20 18:17
Start Date: 04/Jan/20 18:17
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #10316: [BEAM-6857]
Support Dynamic Timers
URL: https://github.com/apache/beam/pull/10316#discussion_r361276068
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java
##########
@@ -94,8 +94,13 @@ public void setTimer(TimerData timerKey) {
@Override
public void setTimer(
- StateNamespace namespace, String timerId, Instant timestamp, TimeDomain
timeDomain) {
- timers.put(timerId, namespace, TimerData.of(timerId, namespace, timestamp,
timeDomain));
+ StateNamespace namespace,
+ String timerId,
+ String timerFamilyId,
+ Instant timestamp,
+ TimeDomain timeDomain) {
+ timers.put(
+ timerId, namespace, TimerData.of(timerId, timerFamilyId, namespace,
timestamp, timeDomain));
Review comment:
This isn't quite right. The idea of having the timer namespace is that two
timers with the same id but different namespaces should not conflict, but right
now they will override each other. We need to make sure that they don't
override each other in every XXXTimerInternals class.
Here this involves making them a key in the table, as well as making it a
part of the timerTag returned. We also must make sure that the default
namespace results in the old tag being generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 366227)
Time Spent: 3h 50m (was: 3h 40m)
> Support dynamic timers
> ----------------------
>
> Key: BEAM-6857
> URL: https://issues.apache.org/jira/browse/BEAM-6857
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The Beam timers API currently requires each timer to be statically specified
> in the DoFn. The user must provide a separate callback method per timer. For
> example:
>
> {code:java}
> DoFn<String, String>()
> {
> @TimerId("timer1")
> private final TimerSpec timer1 = TimerSpecs.timer(...);
> @TimerId("timer2")
> private final TimerSpec timer2 = TimerSpecs.timer(...);
> ...... set timers in processElement
> @OnTimer("timer1")
> public void onTimer1() { .....}
> @OnTimer("timer2")
> public void onTimer2() {....}
> }
> {code}
>
> However there are many cases where the user does not know the set of timers
> statically when writing their code. This happens when the timer tag should be
> based on the data. It also happens when writing a DSL on top of Beam, where
> the DSL author has to create DoFns but does not know statically which timers
> their users will want to set (e.g. Scio).
>
> The goal is to support dynamic timers. Something as follows;
>
> {code:java}
> DoFn<String, String>()
> {
> @TimerId("timer")
> private final TimerSpec timer1 = TimerSpecs.dynamicTimer(...);
> @ProcessElement process(@TimerId("timer") DynamicTimer timer)
> {
> timer.set("tag1'", ts);
> timer.set("tag2", ts);
> }
> @OnTimer("timer")
> public void onTimer1(@TimerTag String tag) { .....}
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
