[
https://issues.apache.org/jira/browse/BEAM-8577?focusedWorklogId=366833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366833
]
ASF GitHub Bot logged work on BEAM-8577:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/20 18:37
Start Date: 06/Jan/20 18:37
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10027: [BEAM-8577]
Initialize FileSystems during Coder deserialization in Re…
URL: https://github.com/apache/beam/pull/10027#discussion_r363423782
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkIdentityFunction.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.flink.translation.functions;
+
+import org.apache.flink.api.common.functions.MapFunction;
+
+/**
+ * A map function that outputs the input element without any change.
+ *
+ * @param <T> Input element type.
+ */
+public class FlinkIdentityFunction<T> implements MapFunction<T, T> {
+
+ private static FlinkIdentityFunction<?> INSTANCE = new
FlinkIdentityFunction<>();
Review comment:
The reason is that the `final` keyword is missing, only final values are
constants and can be capitalized. Fixing this in the merge commit, ensuring
that the tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 366833)
Time Spent: 2h (was: 1h 50m)
> FileSystems may have not be initialized during ResourceId deserialization
> -------------------------------------------------------------------------
>
> Key: BEAM-8577
> URL: https://issues.apache.org/jira/browse/BEAM-8577
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.16.0
> Reporter: David Morávek
> Assignee: David Morávek
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> - FileSystems use static registration using
> *FileSystems#setDefaultPipelineOptions* method.
> - *#setDefaultPipelineOptions* is called either when deserializaing
> SerializablePipelineOptions or during opening of various beam operators.
> - *FileIO#matchAll* is expanded using *Reshuffle.viaRandomKey()*.
> - Reshuffle is implemented using *.rebalance*, that doesn't have a
> "RichFunction" lifecycle, so we need to find another way to register
> FileSystems, as the deserialization may happen before other "rich operators"
> get executed on particular task manager.
> This results in random pipeline fails as the task assignment is not
> deterministic.
> We can workaround this, by registering FileSystems during coder
> deserialization.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
