[
https://issues.apache.org/jira/browse/BEAM-7861?focusedWorklogId=369302&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369302
]
ASF GitHub Bot logged work on BEAM-7861:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 19:49
Start Date: 09/Jan/20 19:49
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #10536: [BEAM-7861]
Add direct_running_mode option for direct runners to switch between
multi_threading and multi_processing easily
URL: https://github.com/apache/beam/pull/10536#discussion_r364929243
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -450,6 +450,21 @@ def run_pipeline(self,
pipeline_options.DirectOptions).direct_runner_bundle_repeat
self._num_workers = options.view_as(
pipeline_options.DirectOptions).direct_num_workers or self._num_workers
+
+ # set direct workers running mode if it is defined with pipeline options.
+ if options.view_as(pipeline_options.DirectOptions).direct_running_mode \
+ is not None:
Review comment:
Could this be None any more? Since it has a default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 369302)
Time Spent: 1h 20m (was: 1h 10m)
> Make it easy to change between multi-process and multi-thread mode for Python
> Direct runners
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-7861
> URL: https://issues.apache.org/jira/browse/BEAM-7861
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> BEAM-3645 makes it possible to run a map task parallel.
> However, users need to change runner when switch between multithreading and
> multiprocessing mode.
> We want to add a flag (ex: --use-multiprocess) to make the switch easy
> without changing the runner each time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
