[
https://issues.apache.org/jira/browse/BEAM-8624?focusedWorklogId=369372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369372
]
ASF GitHub Bot logged work on BEAM-8624:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 21:22
Start Date: 09/Jan/20 21:22
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10115: [BEAM-8624]
Implement Worker Status FnService in Dataflow runner
URL: https://github.com/apache/beam/pull/10115#discussion_r364964289
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/status/BeamWorkerStatusGrpcService.java
##########
@@ -187,4 +194,17 @@ private String getStatusErrorOrInfo(WorkerStatusResponse
response) {
? response.getError()
: response.getStatusInfo();
}
+
+ private String handleAndReturnExceptionResponse(Exception e) {
+ LOG.warn(DEFAULT_EXCEPTION_RESPONSE, e);
+ if (e instanceof InterruptedException) {
+ Thread.currentThread().interrupt();
+ }
+ StringBuilder response = new StringBuilder();
+
response.append(DEFAULT_EXCEPTION_RESPONSE).append(":").append(e.getClass().getCanonicalName());
Review comment:
Add space after `:` here and the line below otherwise the message will look
awkwardly formatted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 369372)
Time Spent: 14.5h (was: 14h 20m)
> Implement FnService for status api in Dataflow runner
> -----------------------------------------------------
>
> Key: BEAM-8624
> URL: https://issues.apache.org/jira/browse/BEAM-8624
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Major
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
