[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=369391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369391
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 21:47
Start Date: 09/Jan/20 21:47
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364974609
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -82,7 +82,7 @@ class PValue(object):
"""
def __init__(self,
- pipeline, # type: Pipeline
+ pipeline, # type: Optional[Pipeline]
Review comment:
The one case where it could be None is when we're deserializing these from a
runner api proto (which you reference below). This is because there is a cycle
between PTransforms and their outputs, and the pipeline as a whole and its
components. It should be populated later and as such documenting as optional
isn't really correct. Is it possible to instead suppress the warning at the
callsite?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 369391)
Time Spent: 43h 20m (was: 43h 10m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 43h 20m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
