[
https://issues.apache.org/jira/browse/BEAM-8537?focusedWorklogId=369490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369490
]
ASF GitHub Bot logged work on BEAM-8537:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 00:38
Start Date: 10/Jan/20 00:38
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10375: [BEAM-8537]
Provide WatermarkEstimator to track watermark
URL: https://github.com/apache/beam/pull/10375#discussion_r365024488
##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -1236,6 +1236,74 @@ def try_claim(self, position):
raise NotImplementedError
+class WatermarkEstimator(object):
+ """A WatermarkEstimator which is used for estimating output_watermark based
on
+ the timestamp of output records or manual modifications.
+
+ The base class provides common APIs that are called by the framework, which
+ are also accessible inside a DoFn.process() body. One derived watermark
+ estimator should implement all framework-called APIs, meanwhile, new added
+ APIs of the derived watermark estimator will also be exposed to a DoFn body.
Review comment:
```suggestion
and will be available when invoked from within a DoFn.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 369490)
Time Spent: 1h 20m (was: 1h 10m)
> Provide WatermarkEstimatorProvider for different types of WatermarkEstimator
> ----------------------------------------------------------------------------
>
> Key: BEAM-8537
> URL: https://issues.apache.org/jira/browse/BEAM-8537
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This is a follow up for in-progress PR:
> https://github.com/apache/beam/pull/9794.
> Current implementation in PR9794 provides a default implementation of
> WatermarkEstimator. For further work, we want to let WatermarkEstimator to be
> a pure Interface. We'll provide a WatermarkEstimatorProvider to be able to
> create a custom WatermarkEstimator per windowed value. It should be similar
> to how we track restriction for SDF:
> WatermarkEstimator <---> RestrictionTracker
> WatermarkEstimatorProvider <---> RestrictionTrackerProvider
> WatermarkEstimatorParam <---> RestrictionDoFnParam
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
