[
https://issues.apache.org/jira/browse/BEAM-6595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012444#comment-17012444
]
Kenneth Knowles commented on BEAM-6595:
---------------------------------------
What has happened is that we have been releasing RCs where the exact commit
with the changed version is not pushed to GitHub.
> build_release_candidate.sh should not push to apache org on github
> ------------------------------------------------------------------
>
> Key: BEAM-6595
> URL: https://issues.apache.org/jira/browse/BEAM-6595
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, the build_release_candidate.sh does many things beyond the build
> - Edits files in place to update the version from SNAPSHOT to non-SNAPSHOT
> - Makes a local commit
> - Pushes commits to release branch
> - Reverts on failure, pushes those to release branch
> Instead, the release manager should determine what gets pushed. It is less
> fragile of a process and avoids cruft getting pushed and churning the branch.
> The only thing the plugin is really good for is flipping SNAPSHOT away and
> back. And it isn't even that great because that's Java only and other
> languages are at non-SNAPSHOT anyhow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
