[
https://issues.apache.org/jira/browse/BEAM-8625?focusedWorklogId=370113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-370113
]
ASF GitHub Bot logged work on BEAM-8625:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 22:43
Start Date: 10/Jan/20 22:43
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #10553: [BEAM-8625]
Implement servlet for exposing sdk harness statuses in Da…
URL: https://github.com/apache/beam/pull/10553#discussion_r365459487
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/SdkWorkerStatusServlet.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.dataflow.worker.status;
+
+import com.google.common.base.Strings;
+import java.io.IOException;
+import java.io.OutputStreamWriter;
+import java.io.PrintWriter;
+import java.nio.charset.StandardCharsets;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+import javax.servlet.ServletException;
+import javax.servlet.ServletOutputStream;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import org.apache.beam.runners.dataflow.worker.status.DebugCapture.Capturable;
+import org.apache.beam.runners.fnexecution.status.BeamWorkerStatusGrpcService;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Servlet dedicated to provide live status info retrieved from SDK Harness.
Note this is different
+ * from {@link WorkerStatusPages} which incorporates all info for Dataflow
runner including this
+ * SDKWorkerStatus page.
+ */
+public class SdkWorkerStatusServlet extends BaseStatusServlet implements
Capturable {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SdkWorkerStatusServlet.class);
+ private final transient BeamWorkerStatusGrpcService statusGrpcService;
+
+ public SdkWorkerStatusServlet(BeamWorkerStatusGrpcService statusGrpcService)
{
+ super("sdk_status");
+ this.statusGrpcService = statusGrpcService;
+ }
+
+ @Override
+ protected String getPath(String parameters) {
+ return super.getPath(parameters);
+ }
+
+ @Override
+ protected void doGet(HttpServletRequest request, HttpServletResponse
response)
+ throws IOException, ServletException {
+ String id = request.getParameter("id");
+ if (Strings.isNullOrEmpty(id)) {
+ // return all connected sdk statuses if no id provided.
+ response.setStatus(HttpServletResponse.SC_OK);
+ response.setContentType("text/html;charset=utf-8");
+ ServletOutputStream writer = response.getOutputStream();
+ try (PrintWriter out =
+ new PrintWriter(new OutputStreamWriter(writer,
StandardCharsets.UTF_8))) {
+ captureData(out);
+ response.flushBuffer();
+ return;
+ }
+ }
+
+ response.setContentType("text/plain;charset=utf-8");
+ response.setStatus(HttpServletResponse.SC_OK);
Review comment:
We can do this before the if block so that it is not duplicated.
```
protected void doGet(HttpServletRequest request, HttpServletResponse
response)
throws IOException, ServletException {
String id = request.getParameter("id");
if (Strings.isNullOrEmpty(id)) {
// return all connected sdk statuses if no id provided.
response.setContentType("text/html;charset=utf-8");
ServletOutputStream writer = response.getOutputStream();
try (PrintWriter out =
new PrintWriter(new OutputStreamWriter(writer,
StandardCharsets.UTF_8))) {
captureData(out);
}
} else {
response.setContentType("text/plain;charset=utf-8");
ServletOutputStream writer = response.getOutputStream();
writer.println(statusGrpcService.getSingleWorkerStatus(id, 10,
TimeUnit.SECONDS););
}
response.setStatus(HttpServletResponse.SC_OK);
response.flushBuffer();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 370113)
Time Spent: 40m (was: 0.5h)
> Implement servlet in Dataflow runner for sdk status query endpoint
> ------------------------------------------------------------------
>
> Key: BEAM-8625
> URL: https://issues.apache.org/jira/browse/BEAM-8625
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
