[
https://issues.apache.org/jira/browse/BEAM-8951?focusedWorklogId=370122&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-370122
]
ASF GitHub Bot logged work on BEAM-8951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 22:53
Start Date: 10/Jan/20 22:53
Worklog Time Spent: 10m
Work Description: markflyhigh commented on pull request #10435:
[BEAM-8951] Stop using nose in load tests
URL: https://github.com/apache/beam/pull/10435#discussion_r365443222
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test.py
##########
@@ -17,19 +17,50 @@
from __future__ import absolute_import
import json
-import logging
-import unittest
from apache_beam.metrics import MetricsFilter
from apache_beam.testing.load_tests.load_test_metrics_utils import
MetricsReader
from apache_beam.testing.test_pipeline import TestPipeline
-class LoadTest(unittest.TestCase):
- def parseTestPipelineOptions(self, options=None):
+class LoadTest(object):
+ def __init__(self):
+ self.pipeline = TestPipeline(is_integration_test=True)
Review comment:
I would suggest to keep `--test-pipeline-options` (either with
`TestPipeline` or other parse approach), which provide great flexibility of
passing pipeline options from command line. With the plan of moving `nose` to
`pytest`, `TestPipeline` will be adopted to `pytest` eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 370122)
> Stop using nose in load tests
> -----------------------------
>
> Key: BEAM-8951
> URL: https://issues.apache.org/jira/browse/BEAM-8951
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kamil Wasilewski
> Assignee: Kamil Wasilewski
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> The community is considering moving away from nose to pytest:
> https://issues.apache.org/jira/browse/BEAM-3713. We should change the way of
> running Python load tests: instead of being subclasses of
> `unittest.TestCase`, they could be plain Python scripts, just like wordcount
> examples. This will bring one additional benefit: _LOAD_TEST_ENABLED_ guard
> will be no longer needed and could be safely removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
