[
https://issues.apache.org/jira/browse/BEAM-9027?focusedWorklogId=370131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-370131
]
ASF GitHub Bot logged work on BEAM-9027:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/20 23:10
Start Date: 10/Jan/20 23:10
Worklog Time Spent: 10m
Work Description: apilloud commented on pull request #10539: [BEAM-9027]
Unparse DOY/DOW/WEEK Enums properly for ZetaSQL
URL: https://github.com/apache/beam/pull/10539#discussion_r365466091
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -3661,7 +3661,6 @@ public void
testExtractTimestampThrowsOnMicrosecondNotSupported() {
/** Only sample scenarios are covered here. Excessive testing is done via
Compliance tests. */
@Test
- @Ignore("ZetaSQL does not support EnumType to IdentifierLiteral")
Review comment:
Limited support for EnumType was added but the tests weren't turned on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 370131)
Time Spent: 4h 50m (was: 4h 40m)
> [SQL] ZetaSQL unparsing should produce valid result
> ---------------------------------------------------
>
> Key: BEAM-9027
> URL: https://issues.apache.org/jira/browse/BEAM-9027
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> * ZetaSQL does not recognize keyword INTERVAL
> * Calcite cannot unparse RexNode back to bytes literal
> * Calcite cannot unparse some floating point literals correctly
> * Calcite cannot unparse some string literals correctly
> * Calcite cannot unparse types correctly for CAST function
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
