[
https://issues.apache.org/jira/browse/BEAM-9061?focusedWorklogId=372559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-372559
]
ASF GitHub Bot logged work on BEAM-9061:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/20 21:27
Start Date: 15/Jan/20 21:27
Worklog Time Spent: 10m
Work Description: udim commented on pull request #10568: [BEAM-9061] Add
version guards to requirements file for integration tests.
URL: https://github.com/apache/beam/pull/10568#discussion_r367116124
##########
File path: sdks/python/scripts/run_integration_test.sh
##########
@@ -194,8 +194,10 @@ if [[ -z $PIPELINE_OPTS ]]; then
fi
# Install test dependencies for ValidatesRunner tests.
- echo "pyhamcrest" > postcommit_requirements.txt
- echo "mock" >> postcommit_requirements.txt
+ # pyhamcrest==1.10.0 doesn't work on Py2.
Review comment:
I don't like adding yet another location with version numbers. I wish we a
single SoT for versioning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 372559)
Time Spent: 1h 20m (was: 1h 10m)
> New release of pyhamcrest==1.10.0 breaks portable Python precommits.
> --------------------------------------------------------------------
>
> Key: BEAM-9061
> URL: https://issues.apache.org/jira/browse/BEAM-9061
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {noformat}
> 08:35:26 File "apache_beam/runners/portability/fn_api_runner_test.py", line
> 38, in <module>
> 08:35:26 import hamcrest # pylint: disable=ungrouped-imports
> 08:35:26 File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/__init__.py",
> line 2, in <module>
> 08:35:26 from hamcrest.library import *
> 08:35:26 File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/__init__.py",
> line 7, in <module>
> 08:35:26 from hamcrest.library.object import *
> 08:35:26 File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/object/__init__.py",
> line 4, in <module>
> 08:35:26 from .hasproperty import has_properties, has_property
> 08:35:26 File
> "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python2_PVR_Flink_Commit/src/build/gradleenv/1866363813/local/lib/python2.7/site-packages/hamcrest/library/object/hasproperty.py",
> line 174
> 08:35:26 ),
> 08:35:26 ^
> {noformat}
> rootcause: https://github.com/hamcrest/PyHamcrest/issues/131
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
