[ https://issues.apache.org/jira/browse/BEAM-8564?focusedWorklogId=373178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373178 ]
ASF GitHub Bot logged work on BEAM-8564: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Jan/20 17:52 Start Date: 16/Jan/20 17:52 Worklog Time Spent: 10m Work Description: amoght commented on pull request #10254: [BEAM-8564] Add LZO compression and decompression support URL: https://github.com/apache/beam/pull/10254#discussion_r367563291 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/LzoCompressorInputStream.java ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.util; + +import io.airlift.compress.lzo.LzoCodec; +import java.io.IOException; +import java.io.InputStream; +import org.apache.commons.compress.compressors.CompressorInputStream; +import org.apache.commons.compress.utils.CountingInputStream; +import org.apache.commons.compress.utils.IOUtils; +import org.apache.commons.compress.utils.InputStreamStatistics; + +/** + * {@link CompressorInputStream} implementation to create LZO encoded stream. Library relies on <a + * href="https://github.com/airlift/aircompressor/">LZO</a> + * + * @since 1.18 + */ +public class LzoCompressorInputStream extends CompressorInputStream Review comment: Where do you suggest to keep static methods? Currently we have wrapper class in util package. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 373178) Time Spent: 7h 10m (was: 7h) > Add LZO compression and decompression support > --------------------------------------------- > > Key: BEAM-8564 > URL: https://issues.apache.org/jira/browse/BEAM-8564 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core > Reporter: Amogh Tiwari > Assignee: Amogh Tiwari > Priority: Minor > Time Spent: 7h 10m > Remaining Estimate: 0h > > LZO is a lossless data compression algorithm which is focused on compression > and decompression speeds. > This will enable Apache Beam sdk to compress/decompress files using LZO > compression algorithm. > This will include the following functionalities: > # compress() : for compressing files into an LZO archive > # decompress() : for decompressing files archived using LZO compression > Appropriate Input and Output stream will also be added to enable working with > LZO files. -- This message was sent by Atlassian Jira (v8.3.4#803005)