[
https://issues.apache.org/jira/browse/BEAM-9122?focusedWorklogId=373372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373372
]
ASF GitHub Bot logged work on BEAM-9122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jan/20 03:26
Start Date: 17/Jan/20 03:26
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #10596: [BEAM-9122]
Add uses_keyed_state step property in python dataflow run…
URL: https://github.com/apache/beam/pull/10596#discussion_r367754044
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -950,6 +950,10 @@ def run_ParDo(self, transform_node, options):
step.add_property(PropertyNames.RESTRICTION_ENCODING,
self._get_cloud_encoding(restriction_coder))
+ from apache_beam.runners.common import DoFnSignature
+ if DoFnSignature(transform.dofn).is_stateful_dofn():
Review comment:
Yes, java side we do the same.
https://github.com/apache/beam/blob/2fd785dedb979a248e63c6385f978fd18fd2fbc4/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java#L1260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 373372)
Time Spent: 1h 20m (was: 1h 10m)
> Add uses_keyed_state step property to python dataflow runner
> ------------------------------------------------------------
>
> Key: BEAM-9122
> URL: https://issues.apache.org/jira/browse/BEAM-9122
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Add additional step property to dataflow job property when a DoFn is stateful
> in python sdk. So that the backend runner can recognize stateful steps.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
