[
https://issues.apache.org/jira/browse/BEAM-9120?focusedWorklogId=375261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375261
]
ASF GitHub Bot logged work on BEAM-9120:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/20 22:37
Start Date: 21/Jan/20 22:37
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10589: [WIP]
[BEAM-9120] Deprecate onSuccessMatcher, onCreateMatcher
URL: https://github.com/apache/beam/pull/10589#discussion_r369281313
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/TestDataflowRunner.java
##########
@@ -102,8 +101,6 @@ DataflowPipelineJob run(Pipeline pipeline, DataflowRunner
runner) {
job.getJobId(),
expectedNumberOfAssertions);
- assertThat(job, testPipelineOptions.getOnCreateMatcher());
Review comment:
Does it do that? My understanding was that this would be a no-op by default,
since OnCreateMatcher is an instance of AlwaysPassMatcher. It will only fail
fast if the user sets an OnCreateMatcher, which I don't think is happening
anywhere outside of TestDataflowRunnerTest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 375261)
Time Spent: 2h (was: 1h 50m)
> Deprecate onSuccessMatcher, onCreateMatcher
> -------------------------------------------
>
> Key: BEAM-9120
> URL: https://issues.apache.org/jira/browse/BEAM-9120
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Instead of creating matchers on PipelineResult we should just make assertions
> on real matchers after waiting for the pipeline to finish.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
