[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=375350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375350
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/20 01:07
Start Date: 22/Jan/20 01:07
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #10368: [BEAM-8335]
Modify PipelineInstrument to add TestStream for unbounded PCollections
URL: https://github.com/apache/beam/pull/10368#discussion_r369325488
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -418,6 +423,45 @@ def _replace_with_cached_inputs(self, pipeline):
cache, noop.
"""
+ # Find all cached unbounded PCollections.
+ class CacheableUnboundedPCollectionVisitor(PipelineVisitor):
+ def __init__(self, pin):
+ self._pin = pin
+ self.unbounded_pcolls = set()
+
+ def enter_composite_transform(self, transform_node):
+ self.visit_transform(transform_node)
+
+ def visit_transform(self, transform_node):
+ if transform_node.inputs:
+ for input_pcoll in transform_node.inputs:
+ key = self._pin.cache_key(input_pcoll)
+ if (key in self._pin._cached_pcoll_read and
+ not input_pcoll.is_bounded):
+ self.unbounded_pcolls.add(key)
+
+ v = CacheableUnboundedPCollectionVisitor(self)
+ pipeline.visit(v)
+
+ # The set of keys from the cached unbounded PCollections will be used as
the
+ # output tags for the TestStream. This is to remember what cache-key is
+ # associated with which PCollection.
+ unbounded_cacheables = v.unbounded_pcolls
+ output_tags = unbounded_cacheables
+
+ # Take the PCollections that will be read from the TestStream and insert
+ # them back into the dictionary of cached PCollections. The next step will
+ # replace the downstream consumer of the non-cached PCollections with these
+ # PCollections.
+ if output_tags:
+ output_pcolls = pipeline |
test_stream.TestStream(output_tags=output_tags)
+ if len(output_tags) == 1:
+ self._cached_pcoll_read[None] = output_pcolls
+ else:
+ for tag, pcoll in output_pcolls.items():
+ self._cached_pcoll_read[tag] = pcoll
Review comment:
nit `self._cached_pcoll_read.update(output_pcolls)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 375350)
Time Spent: 53h 50m (was: 53h 40m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 53h 50m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
