[ 
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=375647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375647
 ]

ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jan/20 15:27
            Start Date: 22/Jan/20 15:27
    Worklog Time Spent: 10m 
      Work Description: aromanenko-dev commented on pull request #10563: 
[BEAM-7310] Add support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#discussion_r369627698
 
 

 ##########
 File path: 
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
 ##########
 @@ -586,6 +612,55 @@ public void setValueDeserializer(String 
valueDeserializer) {
       return 
toBuilder().setValueDeserializer(valueDeserializer).setValueCoder(valueCoder).build();
     }
 
+    /**
+     * Sets a Confluent Schema Registry URL in case of using Avro schema 
serialised key/values. It
+     * should be used together with {@link #withKeySchemaSubject(String)} 
and/or {@link
+     * #withValueSchemaSubject(String)}.
+     */
+    public Read<K, V> withSchemaRegistry(String schemaRegistryUrl) {
 
 Review comment:
   Good question. I think that all different types of authentication can be 
configured through CSR options and will be used by `CachedSchemaRegistryClient` 
if any:
   https://docs.confluent.io/current/schema-registry/security/index.html
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 375647)
    Time Spent: 6.5h  (was: 6h 20m)

> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
>                 Key: BEAM-7310
>                 URL: https://issues.apache.org/jira/browse/BEAM-7310
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-kafka
>    Affects Versions: 2.12.0
>            Reporter: Yohei Shimomae
>            Assignee: Alexey Romanenko
>            Priority: Minor
>          Time Spent: 6.5h
>  Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but  KafkaIO 
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to