[
https://issues.apache.org/jira/browse/BEAM-9072?focusedWorklogId=376674&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376674
]
ASF GitHub Bot logged work on BEAM-9072:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/20 00:56
Start Date: 24/Jan/20 00:56
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10440:
[BEAM-9072] [SQL] DataStoreV1 IO connector
URL: https://github.com/apache/beam/pull/10440#discussion_r370431157
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/schema/BeamTableUtils.java
##########
@@ -137,6 +138,12 @@ public static Object autoCastField(Schema.Field field,
Object rawObj) {
throw new UnsupportedOperationException(
String.format("Column type %s is not supported yet!", type));
}
+ } else if (type.getTypeName().isPrimitiveType()) {
+ if (TypeName.BYTES.equals(type.getTypeName()) && rawObj instanceof
ByteString) {
+ return ((ByteString) rawObj).getBytes();
+ }
+ throw new UnsupportedOperationException(
+ String.format("Column type %s is not supported yet!", type));
Review comment:
Seems like an easy fix is definitely possible. Just need to add a BOOLEAN
case, or remove this UnsupportedOperationException and let it (and other
non-numeric primitive types) fall through.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 376674)
Time Spent: 6h 50m (was: 6h 40m)
> [SQL] Add support for Datastore source
> --------------------------------------
>
> Key: BEAM-9072
> URL: https://issues.apache.org/jira/browse/BEAM-9072
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kirill Kozlov
> Assignee: Kirill Kozlov
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> * Create a Datastore table and table provider
> * Conversion between Datastore and Beam data types
> * Implement buildIOReader
> * Implement buildIOWrite
> * Implement getTableStatistics
> Doc:
> [https://docs.google.com/document/d/1FxuEGewJ3GPDl0IKglfOYf1edwa2m_wryFZYRMpRNbA/edit?pli=1]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
