[
https://issues.apache.org/jira/browse/BEAM-8402?focusedWorklogId=376738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376738
]
ASF GitHub Bot logged work on BEAM-8402:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/20 07:15
Start Date: 24/Jan/20 07:15
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #9811: [BEAM-8402] Create a
class hierarchy to represent environments
URL: https://github.com/apache/beam/pull/9811#issuecomment-578018838
The `default_environment` argument of `FnApiRunner` changed type from
`beam_runner_api_pb2.Environment` to `environment.Environment` subclass. This
tfx code is still passing `beam_runner_api_pb2.Environment`:
https://github.com/tensorflow/tfx/blob/20666f4206b6741d55ed76d9194245600d433da9/tfx/components/base/base_executor.py#L116
Some possible solutions:
1. document the change
2. raise an informative `TypeError` earlier in the process
3. silently convert from `beam_runner_api_pb2.Environment` to
`environment.Environment` subclass
I'd opt for solution 2. Maybe 1 as well, though I'm not sure where this
kind of changelog/announcement is supposed to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 376738)
Time Spent: 5h 20m (was: 5h 10m)
> Create a class hierarchy to represent environments
> --------------------------------------------------
>
> Key: BEAM-8402
> URL: https://issues.apache.org/jira/browse/BEAM-8402
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> As a first step towards making it possible to assign different environments
> to sections of a pipeline, we first need to expose environment classes to the
> pipeline API. Unlike PTransforms, PCollections, Coders, and Windowings,
> environments exists solely in the portability framework as protobuf objects.
> By creating a hierarchy of "native" classes that represent the various
> environment types -- external, docker, process, etc -- users will be able to
> instantiate these and assign them to parts of the pipeline. The assignment
> portion will be covered in a follow-up issue/PR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
