[
https://issues.apache.org/jira/browse/BEAM-5504?focusedWorklogId=377976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377976
]
ASF GitHub Bot logged work on BEAM-5504:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/20 01:28
Start Date: 28/Jan/20 01:28
Worklog Time Spent: 10m
Work Description: milantracy commented on issue #10487: [BEAM-5504]
Introduce PubsubAvroTable
URL: https://github.com/apache/beam/pull/10487#issuecomment-579036611
> Thanks for this @milantracy! Right now my only concern with this is that
it's duplicating a lot of code from the PubsubJsonTableProvider for supporting
both flat and nested schemas. What do you think about adding an abstract
`PubsubTableProvider` that includes the logic for the different types of
schemas, and then each implementation can be responsible for translating the
payload to/from avro or JSON?
>
> That way when we get rid of support for nested schemas we only have to do
it in one place.
@TheNeuralBit Thanks, this is a good idea, I will created a abstract class
`PubsubTableProvider` and two final class `JsonPubsubTableProvider` and
`AvroPubsubTableProvider`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 377976)
Time Spent: 2h 50m (was: 2h 40m)
> PubsubAvroTable
> ---------------
>
> Key: BEAM-5504
> URL: https://issues.apache.org/jira/browse/BEAM-5504
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Jing Chen
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
