[
https://issues.apache.org/jira/browse/BEAM-9175?focusedWorklogId=378423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378423
]
ASF GitHub Bot logged work on BEAM-9175:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/20 19:26
Start Date: 28/Jan/20 19:26
Worklog Time Spent: 10m
Work Description: udim commented on issue #10684: [BEAM-9175] Introduce
an autoformatting tool to Python SDK
URL: https://github.com/apache/beam/pull/10684#issuecomment-579413380
> There is still a number of pylint issues `Wrong continued indentation`.
Most of them appear because of how lambda is formatted. For example:
>
https://github.com/apache/beam/blob/7db61fbf2dd6eac4ffb542e684260edf0d892fea/sdks/python/apache_beam/io/gcp/bigquery_test.py#L908-L910
>
> I don't know yet how to deal with it. Unless there is a knob for this,
I'll just put a # yapf: disable comments in these places.
If we adopt yapf's indentation style, then we can disable the same check in
pylint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 378423)
Time Spent: 3h 50m (was: 3h 40m)
> Introduce an autoformatting tool to Python SDK
> ----------------------------------------------
>
> Key: BEAM-9175
> URL: https://issues.apache.org/jira/browse/BEAM-9175
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core, sdk-py-harness
> Reporter: Michał Walenia
> Assignee: Kamil Wasilewski
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> It seems there are three main options:
> * black - very simple, but not configurable at all (except for line length),
> would drastically change code style
> * yapf - more options to tweak, can omit parts of code
> * autopep8 - more similar to spotless - only touches code that breaks
> formatting guidelines, can use pycodestyle and flake8 as configuration
> The rigidity of Black makes it unusable for Beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
