[
https://issues.apache.org/jira/browse/BEAM-6703?focusedWorklogId=380086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380086
]
ASF GitHub Bot logged work on BEAM-6703:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/20 16:53
Start Date: 31/Jan/20 16:53
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10689: [BEAM-6703]
Make Dataflow ValidatesRunner test use Java 11 in test execution
URL: https://github.com/apache/beam/pull/10689#discussion_r373580421
##########
File path:
.test-infra/jenkins/job_PostCommit_Java_ValidatesRunner_Dataflow_Java11.groovy
##########
@@ -20,26 +20,40 @@ import CommonJobProperties as commonJobProperties
import PostcommitJobBuilder
-PostcommitJobBuilder.postCommitJob('beam_PostCommit_Java11_ValidatesRunner_Dataflow',
+PostcommitJobBuilder.postCommitJob('beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11',
'Run Dataflow ValidatesRunner Java 11', 'Google Cloud Dataflow Runner
ValidatesRunner Tests On Java 11', this) {
description('Runs the ValidatesRunner suite on the Dataflow runner with Java
11 worker harness.')
- commonJobProperties.setTopLevelMainJobProperties(delegate, 'master', 270)
+ def JAVA_11_HOME = '/usr/lib/jvm/java-11-openjdk-amd64'
+ def JAVA_8_HOME = '/usr/lib/jvm/java-8-openjdk-amd64'
+ commonJobProperties.setTopLevelMainJobProperties(delegate, 'master', 270)
publishers {
archiveJunit('**/build/test-results/**/*.xml')
}
steps {
+ gradle {
+ rootBuildScriptDir(commonJobProperties.checkoutDir)
+ tasks(':runners:google-cloud-dataflow-java:testJar')
+
tasks(':runners:google-cloud-dataflow-java:worker:legacy-worker:shadowJar')
+ switches("-Dorg.gradle.java.home=${JAVA_8_HOME}")
+ }
+
gradle {
rootBuildScriptDir(commonJobProperties.checkoutDir)
tasks(':runners:google-cloud-dataflow-java:validatesJava11Runner')
Review comment:
Shouldn't java.specification.version come automatically from the JVM and if
we are using a Java 11 virtual machine, it should already provide
java.specification.version of 11 while a Java 8 virtual machine would specify 8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 380086)
Time Spent: 18h 50m (was: 18h 40m)
> Support Java 11 in Jenkins
> --------------------------
>
> Key: BEAM-6703
> URL: https://issues.apache.org/jira/browse/BEAM-6703
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow, runner-direct
> Reporter: Michał Walenia
> Assignee: Michał Walenia
> Priority: Minor
> Fix For: Not applicable
>
> Time Spent: 18h 50m
> Remaining Estimate: 0h
>
> In this issue I'll create a Jenkins job that compiles Dataflow and Direct
> runners with tests using Java 8 and runs Validates Runner suites with Java 11
> Runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
