[ https://issues.apache.org/jira/browse/BEAM-8280?focusedWorklogId=380232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380232 ]
ASF GitHub Bot logged work on BEAM-8280: ---------------------------------------- Author: ASF GitHub Bot Created on: 31/Jan/20 22:32 Start Date: 31/Jan/20 22:32 Worklog Time Spent: 10m Work Description: udim commented on pull request #10735: [BEAM-8280][BEAM-8629] Make IOTypeHints immutable URL: https://github.com/apache/beam/pull/10735#discussion_r373714584 ########## File path: sdks/python/apache_beam/typehints/decorators.py ########## @@ -283,16 +301,19 @@ def from_callable(fn): output_args.append(typehints.Any) return IOTypeHints(input_types=(tuple(input_args), input_kwargs), - output_types=(tuple(output_args), {})) + output_types=(tuple(output_args), {}), + origin=cls._make_traceback(None)) - def set_input_types(self, *args, **kwargs): - self.input_types = args, kwargs + def with_input_types(self, *args, **kwargs): # type: (...) -> IOTypeHints Review comment: ```suggestion def with_input_types(self, *args, **kwargs): # type: (...) -> IOTypeHints ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 380232) Time Spent: 1h 40m (was: 1.5h) > re-enable IOTypeHints.from_callable > ----------------------------------- > > Key: BEAM-8280 > URL: https://issues.apache.org/jira/browse/BEAM-8280 > Project: Beam > Issue Type: Bug > Components: sdk-py-core > Reporter: Udi Meiri > Assignee: Udi Meiri > Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > See https://issues.apache.org/jira/browse/BEAM-8279 -- This message was sent by Atlassian Jira (v8.3.4#803005)