[ https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=380964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380964 ]
ASF GitHub Bot logged work on BEAM-7310: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Feb/20 13:53 Start Date: 03/Feb/20 13:53 Worklog Time Spent: 10m Work Description: iemejia commented on pull request #10563: [BEAM-7310] Add support of Confluent Schema Registry for KafkaIO URL: https://github.com/apache/beam/pull/10563#discussion_r374110449 ########## File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/TestCSRClientProvider.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.kafka; + +import io.confluent.kafka.schemaregistry.client.MockSchemaRegistryClient; +import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient; +import io.confluent.kafka.schemaregistry.client.rest.exceptions.RestClientException; +import java.io.IOException; +import org.apache.avro.Schema; + +/** Mock implementation of {@link CSRClientProvider} used for testing. */ +public class TestCSRClientProvider extends BasicCSRClientProvider { Review comment: Move this file better `src/test/java` and make the class package private ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 380964) Time Spent: 11.5h (was: 11h 20m) > Confluent Schema Registry support in KafkaIO > -------------------------------------------- > > Key: BEAM-7310 > URL: https://issues.apache.org/jira/browse/BEAM-7310 > Project: Beam > Issue Type: Improvement > Components: io-java-kafka > Affects Versions: 2.12.0 > Reporter: Yohei Shimomae > Assignee: Alexey Romanenko > Priority: Minor > Time Spent: 11.5h > Remaining Estimate: 0h > > Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO > does not support Confluent Schema Registry as discussed here. > https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ > https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)