[ 
https://issues.apache.org/jira/browse/BEAM-8458?focusedWorklogId=381138&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381138
 ]

ASF GitHub Bot logged work on BEAM-8458:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/20 18:51
            Start Date: 03/Feb/20 18:51
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on pull request #9852: 
[BEAM-8458] Add option to set temp dataset in BigQueryIO.Read
URL: https://github.com/apache/beam/pull/9852#discussion_r374273965
 
 

 ##########
 File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
 ##########
 @@ -1342,16 +1354,23 @@ void cleanup(ContextContainer c) throws Exception {
               BigQueryOptions options = 
c.getPipelineOptions().as(BigQueryOptions.class);
               String jobUuid = c.getJobId();
 
+              Optional<String> queryTempDataset = 
Optional.ofNullable(getQueryTempDataset());
 
 Review comment:
   If dataset is provided by the user we should try to validate (before 
pipeline submission) that it exists. (unless user specified withoutValidation())
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 381138)

> BigQueryIO.Read needs permissions to create datasets to be able to run queries
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-8458
>                 URL: https://issues.apache.org/jira/browse/BEAM-8458
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>            Reporter: Israel Herraiz
>            Assignee: Israel Herraiz
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> When using {{fromQuery}}, BigQueryIO creates a temp dataset to store the 
> results of the query.
> Therefore, Beam requires permissions to create datasets just to be able to 
> run a query. In practice, this means that Beam requires the role 
> bigQuery.User just to run queries, whereas if you use {{from}} (to read from 
> a table), the role bigQuery.jobUser suffices.
> BigQueryIO.Read should have an option to set an existing dataset  to write 
> the temp results of
>  a query, so it would be enough with having the role bigQuery.jobUser.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to