[
https://issues.apache.org/jira/browse/BEAM-4150?focusedWorklogId=381903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381903
]
ASF GitHub Bot logged work on BEAM-4150:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/20 22:08
Start Date: 04/Feb/20 22:08
Worklog Time Spent: 10m
Work Description: lostluck commented on issue #10755: [BEAM-4150] Remove
fallback case for coder not specified within RemoteGrpcPort.
URL: https://github.com/apache/beam/pull/10755#issuecomment-582139562
Whoops. Dead comment I thought I deleted after answering my own question
after expanding how much code was revealed.
On Tue, Feb 4, 2020, 1:20 PM Lukasz Cwik <notificati...@github.com> wrote:
> Tthey always have one.
>
> On Tue, Feb 4, 2020 at 11:04 AM Robert Burke <notificati...@github.com>
> wrote:
>
> > *@lostluck* commented on this pull request.
> > ------------------------------
> >
> > In sdks/go/pkg/beam/core/runtime/exec/translate.go
> > <https://github.com/apache/beam/pull/10755#discussion_r374863985>:
> >
> > > @@ -64,6 +64,13 @@ func UnmarshalPlan(desc
> *fnpb.ProcessBundleDescriptor) (*Plan, error) {
> > }
> >
> > u := &DataSource{UID: b.idgen.New()}
> > + u.Coder, err = b.coders.Coder(cid) // Expected to be windowed coder
> > + if err != nil {
> > + return nil, err
> > + }
> > + if !coder.IsW(u.Coder) {
> > + return nil, errors.Errorf("unwindowed coder %v on DataSource %v: %v",
> cid, id, u.Coder)
> > + }
> >
> > for key, pid := range transform.GetOutputs() {
> >
> > Do GRPC datasources always only have a single output?
> >
> > I note that we aren't using the pid, in the new code.
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
>
https://github.com/apache/beam/pull/10755?email_source=notifications&email_token=ACM4V3D4ENJGCCU7DCMAVXLRBG333A5CNFSM4KPKV7XKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUG4ZCI#pullrequestreview-353225865
> >,
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/ACM4V3AXN6VNEWJK3UURZZ3RBG333ANCNFSM4KPKV7XA
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/10755?email_source=notifications&email_token=ADKDOFKM6KGP2G7D7HTUARLRBHLZ5A5CNFSM4KPKV7XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZHI4I#issuecomment-582120561>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ADKDOFIPMLRNDWOLYIXBSOLRBHLZ5ANCNFSM4KPKV7XA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 381903)
Time Spent: 5h (was: 4h 50m)
> Standardize use of PCollection coder proto attribute
> ----------------------------------------------------
>
> Key: BEAM-4150
> URL: https://issues.apache.org/jira/browse/BEAM-4150
> Project: Beam
> Issue Type: Task
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Luke Cwik
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> In some places it's expected to be a WindowedCoder, in others the raw
> ElementCoder. We should use the same convention (decided in discussion to be
> the raw ElementCoder) everywhere. The WindowCoder can be pulled out of the
> attached windowing strategy, and the input/output ports should specify the
> encoding directly rather than read the adjacent PCollection coder fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
