[
https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=381940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381940
]
ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/20 23:06
Start Date: 04/Feb/20 23:06
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #10766:
[BEAM-4461] Add Selected.flattenedSchema
URL: https://github.com/apache/beam/pull/10766#discussion_r374969691
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectHelpers.java
##########
@@ -344,4 +352,46 @@ private static void selectIntoRowWithQualifiers(
throw new RuntimeException("Unexpected type " + qualifier.getKind());
}
}
+
+ /**
+ * This is the default naming policy for naming fields. Every field name in
the path to a given
+ * field is concated with _ characters.
+ */
Review comment:
bike-shed: Nothing in this file actually makes this a default, seems to be a
hold-over from when the function was in `Unnest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 381940)
Time Spent: 29h 10m (was: 29h)
> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
> Key: BEAM-4461
> URL: https://issues.apache.org/jira/browse/BEAM-4461
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 29h 10m
> Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
