[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383518 ]
ASF GitHub Bot logged work on BEAM-9146: ---------------------------------------- Author: ASF GitHub Bot Created on: 07/Feb/20 12:30 Start Date: 07/Feb/20 12:30 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583370245 > > Got one question regarding the naming. Is `video_intelligence` a good name for the module? I'm slightly worried it might cause confusion with the `google.cloud.videointelligence`. > > I think it is a good name reflects the underlying service as it is. Not very different from other gcp io with the similar names to the gcp services. I started work on https://issues.apache.org/jira/browse/BEAM-9247 to integrate the vision API in a similar PTransform. However, here the naming gets more complex. Consider e.g. ``` from google.cloud import vision from apache_beam.ml.gcp import vision ``` One solution for the `vision` transforms is to rename the module `vision_api` instead. But I think we should be consistent across the different GCP ML APIs, so perhaps `video_intelligence` will need renaming too. What's your take? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 383518) Time Spent: 4h 50m (was: 4h 40m) > [Python] PTransform that integrates Video Intelligence functionality > -------------------------------------------------------------------- > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp > Reporter: Kamil Wasilewski > Assignee: Kamil Wasilewski > Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)