[
https://issues.apache.org/jira/browse/BEAM-9269?focusedWorklogId=385085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385085
]
ASF GitHub Bot logged work on BEAM-9269:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/20 11:14
Start Date: 11/Feb/20 11:14
Worklog Time Spent: 10m
Work Description: nielm commented on pull request #10752: [BEAM-9269] Add
commit deadline for Spanner writes.
URL: https://github.com/apache/beam/pull/10752#discussion_r377571907
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerConfig.java
##########
@@ -42,6 +50,10 @@
private static final String USER_AGENT_PREFIX = "Apache_Beam_Java";
// A default host name for batch traffic.
private static final String DEFAULT_HOST =
"https://batch-spanner.googleapis.com/";;
+ // Deadline for Commit API call.
+ private static final Duration DEFAULT_COMMIT_DEADLINE =
Duration.standardSeconds(15);
Review comment:
Configurable using SpannerIO.Write.withCommitDeadline()
as is DEFAULT_MAX_CUMULATIVE_BACKOFF with
SpannerIO.Write.withMaxCumulativeBackoff()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 385085)
Time Spent: 1h 40m (was: 1.5h)
> Set shorter Commit Deadline and handle with backoff/retry
> ---------------------------------------------------------
>
> Key: BEAM-9269
> URL: https://issues.apache.org/jira/browse/BEAM-9269
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.16.0, 2.17.0, 2.18.0, 2.19.0
> Reporter: Niel Markwick
> Assignee: Niel Markwick
> Priority: Major
> Labels: google-cloud-spanner
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Default commit deadline in Spanner is 1hr, which can lead to a variety of
> issues including database overload and session expiry.
> Shorter deadline should be set with backoff/retry when deadline expires, so
> that the Spanner database does not become overloaded.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
