[
https://issues.apache.org/jira/browse/BEAM-7198?focusedWorklogId=385578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385578
]
ASF GitHub Bot logged work on BEAM-7198:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/20 00:37
Start Date: 12/Feb/20 00:37
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #10828: [BEAM-7198] rename
ToStringCoder to ToBytesCoder for proper representation of its role
URL: https://github.com/apache/beam/pull/10828#issuecomment-584945917
Changes LGTM, we can merge once tests pass. Thanks a lot, @lazylynx !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 385578)
Time Spent: 50m (was: 40m)
> Rename ToStringCoder into ToBytesCoder
> --------------------------------------
>
> Key: BEAM-7198
> URL: https://issues.apache.org/jira/browse/BEAM-7198
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: yoshiki obata
> Priority: Minor
> Labels: easy-fix, starter
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The name of ToStringCoder class [1] is confusing, since the output of
> encode() on Python3 will be bytes. On Python 2 the output is also bytes,
> since bytes and string are synonyms on Py2.
> ToBytesCoder would be a better name for this class.
> Note that this class is not listed in coders that constitute Public APIs [2],
> so we can treat this as internal change. As a courtesy to users who happened
> to reference a non-public coder in their pipelines we can keep the old class
> name as an alias, e.g. ToStringCoder = ToBytesCoder to avoid friction, but
> clean up Beam codeabase to use the new name.
> [1]
> https://github.com/apache/beam/blob/ef4b2ef7e5fa2fb87e1491df82d2797947f51be9/sdks/python/apache_beam/coders/coders.py#L344
> [2]
> https://github.com/apache/beam/blob/ef4b2ef7e5fa2fb87e1491df82d2797947f51be9/sdks/python/apache_beam/coders/coders.py#L20
> cc: [~yoshiki.obata] [~chamikara]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
