[ 
https://issues.apache.org/jira/browse/BEAM-9286?focusedWorklogId=389339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389339
 ]

ASF GitHub Bot logged work on BEAM-9286:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Feb/20 06:41
            Start Date: 19/Feb/20 06:41
    Worklog Time Spent: 10m 
      Work Description: HuangLED commented on issue #10823: [BEAM-9286] Create 
validation runner test for metrics (user counter). 
URL: https://github.com/apache/beam/pull/10823#issuecomment-588058804
 
 
   > I'm surprised we don't already have a test for such a basic feature.
   > 
   > FYI, you can use yapf to format your code: 
https://cwiki.apache.org/confluence/display/BEAM/Python+Tips
   
   Thanks Robert.  I was able to only find much a larger test that covers user 
counters, where counter verification is just small part of the whole thing. 
With a dedicated self-contained test for metrics, we may also keep adding other 
metrics related things here. 
   
   PR updated.  Also applied yapf.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 389339)
    Time Spent: 2h 10m  (was: 2h)

> Create validation tests for metrics based on MonitoringInfo if applicable
> -------------------------------------------------------------------------
>
>                 Key: BEAM-9286
>                 URL: https://issues.apache.org/jira/browse/BEAM-9286
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-harness
>            Reporter: Ruoyun Huang
>            Assignee: Ruoyun Huang
>            Priority: Minor
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Create dedicated validation runner tests for metrics (those based Monitoring 
> Info). 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to