[ https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=389591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389591 ]
ASF GitHub Bot logged work on BEAM-8335: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Feb/20 19:55 Start Date: 19/Feb/20 19:55 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10892: [BEAM-8335] Make TestStream to/from runner_api include the output_tags property. URL: https://github.com/apache/beam/pull/10892#discussion_r381507573 ########## File path: sdks/python/apache_beam/runners/direct/test_stream_impl.py ########## @@ -45,11 +46,69 @@ class _WatermarkController(PTransform): - If the instance receives an ElementEvent, it emits all specified elements to the Global Window with the event time set to the element's timestamp. """ + def __init__(self, output_tag): + self.output_tag = output_tag + def get_windowing(self, _): return core.Windowing(window.GlobalWindows()) def expand(self, pcoll): - return pvalue.PCollection.from_(pcoll) + ret = pvalue.PCollection.from_(pcoll) + ret.tag = self.output_tag + return ret + + +class _ExpandableTestStream(PTransform): + def __init__(self, test_stream): + self.test_stream = test_stream + + def expand(self, pbegin): + """Expands the TestStream into the DirectRunner implementation. + + + Takes the TestStream transform and creates a _TestStream -> multiplexer -> + _WatermarkController. + """ + + assert isinstance(pbegin, pvalue.PBegin) + + # If there is only one tag there is no need to add the multiplexer. + if len(self.test_stream.output_tags) == 1: + return ( + pbegin + | _TestStream( + self.test_stream.output_tags, + events=self.test_stream._events, + coder=self.test_stream.coder) + | _WatermarkController(list(self.test_stream.output_tags)[0])) + + # This multiplexing the multiple output PCollections. Review comment: ```suggestion # Multiplex to the correct PCollection based upon the event tag. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 389591) Time Spent: 61.5h (was: 61h 20m) > Add streaming support to Interactive Beam > ----------------------------------------- > > Key: BEAM-8335 > URL: https://issues.apache.org/jira/browse/BEAM-8335 > Project: Beam > Issue Type: Improvement > Components: runner-py-interactive > Reporter: Sam Rohde > Assignee: Sam Rohde > Priority: Major > Time Spent: 61.5h > Remaining Estimate: 0h > > This issue tracks the work items to introduce streaming support to the > Interactive Beam experience. This will allow users to: > * Write and run a streaming job in IPython > * Automatically cache records from unbounded sources > * Add a replay experience that replays all cached records to simulate the > original pipeline execution > * Add controls to play/pause/stop/step individual elements from the cached > records > * Add ability to inspect/visualize unbounded PCollections -- This message was sent by Atlassian Jira (v8.3.4#803005)