[
https://issues.apache.org/jira/browse/BEAM-9339?focusedWorklogId=389763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389763
]
ASF GitHub Bot logged work on BEAM-9339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 02:47
Start Date: 20/Feb/20 02:47
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #10908:
[BEAM-9339] Declare capabilities for Python SDK.
URL: https://github.com/apache/beam/pull/10908#discussion_r381690351
##########
File path: sdks/python/apache_beam/transforms/environments_test.py
##########
@@ -53,10 +63,14 @@ def test_environment_encoding(self):
state_cache_size=0, data_buffer_time_limit_ms=0),
SubprocessSDKEnvironment(command_string=u'foö')):
context = pipeline_context.PipelineContext()
- self.assertEqual(
- environment,
- Environment.from_runner_api(
- environment.to_runner_api(context), context))
+ proto = environment.to_runner_api(context)
+ reconstructed = Environment.from_runner_api(proto, context)
+ self.assertEqual(environment, reconstructed)
+ self.assertEqual(proto, reconstructed.to_runner_api(context))
+
+ def test_sdk_capabilities(self):
+ sdk_capabilities = environments.python_sdk_capabilities()
+ self.assertIn(common_urns.coders.LENGTH_PREFIX.urn, sdk_capabilities)
Review comment:
Probably test for every expected capability here ? And also force failure if
the test has not been updated to reflect a new capability ?
The test can be updated as the list of capabilities are updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 389763)
Time Spent: 1h (was: 50m)
> Declare capabilities in SDK environments
> ----------------------------------------
>
> Key: BEAM-9339
> URL: https://issues.apache.org/jira/browse/BEAM-9339
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
