[
https://issues.apache.org/jira/browse/BEAM-9347?focusedWorklogId=391024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-391024
]
ASF GitHub Bot logged work on BEAM-9347:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/20 02:00
Start Date: 22/Feb/20 02:00
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #10919: [BEAM-9347]
Don't overwrite default runner harness for unified worker
URL: https://github.com/apache/beam/pull/10919#discussion_r382876017
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -186,8 +186,11 @@ def __init__(self, packages, options,
environment_version, pipeline_url):
if job_type.startswith('FNAPI_'):
self.debug_options = self.debug_options or DebugOptions()
self.debug_options.experiments = self.debug_options.experiments or []
+ # Don't add the default image overwrite if user overwrites or
Review comment:
Also, should we be passing pipeline_options instead of debug options?
Perhaps it works either way but passing pipeline options would be cleaner since
that's what the signature of _use_unified_worker() expects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 391024)
Time Spent: 1h (was: 50m)
> Remove default image for Unified Worker
> ---------------------------------------
>
> Key: BEAM-9347
> URL: https://issues.apache.org/jira/browse/BEAM-9347
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The runner will choose the Runner Harness image for UW so we don't need to
> overwrite the image in default behavior.
> Also, this will help us distinguish between user requested overwrites for the
> default overwrites(which is not used).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
