[
https://issues.apache.org/jira/browse/BEAM-8564?focusedWorklogId=392677&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392677
]
ASF GitHub Bot logged work on BEAM-8564:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 16:51
Start Date: 25/Feb/20 16:51
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10254: [BEAM-8564]
Add LZO compression and decompression support
URL: https://github.com/apache/beam/pull/10254#discussion_r383993034
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/LzoCompression.java
##########
@@ -22,58 +22,52 @@
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
-import org.apache.hadoop.io.compress.CompressionInputStream;
-import org.apache.hadoop.io.compress.CompressionOutputStream;
public class LzoCompression {
/**
- * Create a {@link CompressionInputStream} that will read from the given
{@link InputStream} using
- * {@link LzoCodec}.
+ * Create a {@link InputStream} that will read from the given {@link
InputStream} using {@link
+ * LzoCodec}.
*
* @param inputStream the stream to read compressed bytes from
* @return a stream to read uncompressed bytes from
* @throws IOException
*/
- public static CompressionInputStream createLzoInputStream(InputStream
inputStream)
- throws IOException {
+ public static InputStream createLzoInputStream(InputStream inputStream)
throws IOException {
return new LzoCodec().createInputStream(inputStream);
}
/**
- * Create a {@link CompressionInputStream} that will read from the given
{@link InputStream} using
- * {@link LzopCodec}.
+ * Create a {@link InputStream} that will read from the given {@link
InputStream} using {@link
+ * LzopCodec}.
*
* @param inputStream the stream to read compressed bytes from
* @return a stream to read uncompressed bytes from
* @throws IOException
*/
- public static CompressionInputStream createLzopInputStream(InputStream
inputStream)
- throws IOException {
+ public static InputStream createLzopInputStream(InputStream inputStream)
throws IOException {
return new LzopCodec().createInputStream(inputStream);
}
/**
- * Create a {@link CompressionOutputStream} that will write to the given
{@link OutputStream}.
+ * Create a {@link OutputStream} that will write to the given {@link
OutputStream}.
Review comment:
```suggestion
* Create an {@link OutputStream} that will write to the given {@link
OutputStream}.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392677)
Time Spent: 16.5h (was: 16h 20m)
> Add LZO compression and decompression support
> ---------------------------------------------
>
> Key: BEAM-8564
> URL: https://issues.apache.org/jira/browse/BEAM-8564
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Amogh Tiwari
> Assignee: Amogh Tiwari
> Priority: Minor
> Time Spent: 16.5h
> Remaining Estimate: 0h
>
> LZO is a lossless data compression algorithm which is focused on compression
> and decompression speeds.
> This will enable Apache Beam sdk to compress/decompress files using LZO
> compression algorithm.
> This will include the following functionalities:
> # compress() : for compressing files into an LZO archive
> # decompress() : for decompressing files archived using LZO compression
> Appropriate Input and Output stream will also be added to enable working with
> LZO files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
