[
https://issues.apache.org/jira/browse/BEAM-9342?focusedWorklogId=392922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392922
]
ASF GitHub Bot logged work on BEAM-9342:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 21:05
Start Date: 25/Feb/20 21:05
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10970: [BEAM-9342]
Exclude module-info.class from vendored Byte Buddy 1.10.8
URL: https://github.com/apache/beam/pull/10970#discussion_r384124895
##########
File path: vendor/bytebuddy-1_10_8/build.gradle
##########
@@ -28,6 +28,9 @@ vendorJava(
relocations: [
"net.bytebuddy": "org.apache.beam.vendor.bytebuddy.v1_10_8.net.bytebuddy"
],
+ exclusions: [
+ "META-INF/versions/9/module-info.class"
Review comment:
We should exclude it regardless where it appears. This also matches how its
being excluded in vendored gRPC.
```suggestion
"module-info.class"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 392922)
Time Spent: 2h 20m (was: 2h 10m)
> Update bytebuddy to version 1.10.8
> ----------------------------------
>
> Key: BEAM-9342
> URL: https://issues.apache.org/jira/browse/BEAM-9342
> Project: Beam
> Issue Type: Improvement
> Components: build-system, sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The version of bytebuddy Beam is using does not officially support Java 11
> and it is more than 1 year old. We should upgrade to a more recent version so
> we can benefit of the new improvements of the library as well as of ASM.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
