[
https://issues.apache.org/jira/browse/BEAM-6374?focusedWorklogId=392928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392928
]
ASF GitHub Bot logged work on BEAM-6374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 21:09
Start Date: 25/Feb/20 21:09
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #10942: [BEAM-6374]
Emit PCollection metrics from GoSDK
URL: https://github.com/apache/beam/pull/10942#discussion_r383583118
##########
File path: sdks/go/pkg/beam/core/runtime/exec/plan.go
##########
@@ -178,19 +160,25 @@ func (p *Plan) String() string {
return fmt.Sprintf("Plan[%v]:\n%v", p.ID(), strings.Join(units, "\n"))
}
-// Progress returns a snapshot of input progress of the plan, and associated
metrics.
-func (p *Plan) Progress() (ProgressReportSnapshot, bool) {
- if p.source != nil {
- return p.source.Progress(), true
- }
- return ProgressReportSnapshot{}, false
+// PlanSnapshot contains system metrics for the current run of the plan.
+type PlanSnapshot struct {
+ Source ProgressReportSnapshot
+ PCols []PCollectionSnapshot
}
-// Store returns the metric store for the last use of this plan.
-func (p *Plan) Store() *metrics.Store {
- p.storeMu.Lock()
- defer p.storeMu.Unlock()
- return p.store
+// Progress returns a snapshot of progress of the plan, and associated metrics.
Review comment:
This comment should probably be updated to explain that the bool returned
represents whether the snapshot has a DataSource, as opposed to the usual
assumption of an "ok" value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 392928)
Time Spent: 0.5h (was: 20m)
> "elements added" for input and output collections is always empty
> -----------------------------------------------------------------
>
> Key: BEAM-6374
> URL: https://issues.apache.org/jira/browse/BEAM-6374
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow, sdk-go
> Reporter: Andrew Brampton
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The field for "Elements added" and "Estimated size" is always blank when
> running a Go binary on Dataflow. For example when running the work count
> example: https://pasteboard.co/HVf80BU.png
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
