[ https://issues.apache.org/jira/browse/BEAM-9252?focusedWorklogId=393141&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393141 ]
ASF GitHub Bot logged work on BEAM-9252: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Feb/20 02:30 Start Date: 26/Feb/20 02:30 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #10963: [BEAM-9252] Update to vendored gRPC without problematic module-info.class and Main.class URL: https://github.com/apache/beam/pull/10963 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 393141) Time Spent: 3.5h (was: 3h 20m) > Problem shading Beam pipeline with Beam 2.20.0-SNAPSHOT > ------------------------------------------------------- > > Key: BEAM-9252 > URL: https://issues.apache.org/jira/browse/BEAM-9252 > Project: Beam > Issue Type: Bug > Components: build-system > Affects Versions: 2.20.0 > Reporter: Ismaël Mejía > Assignee: Luke Cwik > Priority: Critical > Fix For: 2.20.0 > > Attachments: ArrayIndexOutOfBoundsException.png, > image-2020-02-21-13-22-01-341.png > > Time Spent: 3.5h > Remaining Estimate: 0h > > I was checking today a pipeline against the latest 2.20.0-SNAPSHOT and I > found that it works perfectly with version 2.19.0, but it is failing with a > shade related exception that refers to grpc 1.26.0: > {{[ERROR] Failed to execute goal > org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade (default) on project > EventsToIOs: Error creating shaded jar: Problem shading JAR > /home/ismael/.m2/repository/org/apache/beam/beam-vendor-grpc-1_26_0/0.1/beam-vendor-grpc-1_26_0-0.1.jar > entry org/apache/beam/vendor/grpc/v1p26p0/org/jboss/modules/Main.class: > org.apache.maven.plugin.MojoExecutionException: Error in ASM processing class > org/apache/beam/vendor/grpc/v1p26p0/org/jboss/modules/Main.class: 65536 -> > [Help 1]}} > {{There is also a warning that is not present in the build against 2.19.0}} > {{[WARNING] Discovered module-info.class. Shading will break its strong > encapsulation.}} > > I wonder if we are not doing something wrong during our vendoring, can > someone take a look please. > This is relatively easy to reproduce with the beam-samples repo, just clone > it and run: > {noformat} > git clone https://github.com/jbonofre/beam-samples > mvn clean verify -Pbeam-release-repo -Dbeam.version=2.20.0-SNAPSHOT > {noformat} > Available logs of the latest run: > [https://github.com/jbonofre/beam-samples/runs/427537544?check_suite_focus=true] > -- This message was sent by Atlassian Jira (v8.3.4#803005)