[
https://issues.apache.org/jira/browse/BEAM-9322?focusedWorklogId=393726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393726
]
ASF GitHub Bot logged work on BEAM-9322:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/20 19:45
Start Date: 26/Feb/20 19:45
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #10934: [BEAM-9322]
[BEAM-1833] Broke some people, setting the default to have the experiment be
disabled
URL: https://github.com/apache/beam/pull/10934#issuecomment-591608825
My suggestion, would be to merge this and not change the behavior for 2.20.
The reason is, we think from Google's internal users that this might impact
about ~1% of the users. I do not believe we have time to improve this in time
for the release branch cut happening today and I will error on not breaking any
users.
Counter point is: 1% is not very large and we can force a small group of
users to set a flag to use a newer version. (I still think it is better to make
this decision without the time pressure of immenant release cut.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 393726)
Time Spent: 1h (was: 50m)
> Python SDK ignores manually set PCollection tags
> ------------------------------------------------
>
> Key: BEAM-9322
> URL: https://issues.apache.org/jira/browse/BEAM-9322
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The Python SDK currently ignores any tags set on PCollections manually when
> applying PTransforms when adding the PCollection to the PTransform
> [outputs|[https://github.com/apache/beam/blob/688a4ea53f315ec2aa2d37602fd78496fca8bb4f/sdks/python/apache_beam/pipeline.py#L595]].
> In the
> [add_output|[https://github.com/apache/beam/blob/688a4ea53f315ec2aa2d37602fd78496fca8bb4f/sdks/python/apache_beam/pipeline.py#L872]]
> method, the tag is set to None for all PValues, meaning the output tags are
> set to an enumeration index over the PCollection outputs. The tags are not
> propagated to correctly which can be a problem on relying on the output
> PCollection tags to match the user set values.
> The fix is to correct BEAM-1833, and always pass in the tags. However, that
> doesn't fix the problem for nested PCollections. If you have a dict of lists
> of PCollections, what should their tags be correctly set to? In order to fix
> this, first propagate the correct tag then talk with the community about the
> best auto-generated tags.
> Some users may rely on the old implementation, so a flag will be created:
> "force_generated_pcollection_output_ids" and be default set to False. If
> True, this will go to the old implementation and generate tags for
> PCollections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
