[
https://issues.apache.org/jira/browse/BEAM-9331?focusedWorklogId=394021&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394021
]
ASF GitHub Bot logged work on BEAM-9331:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/20 08:14
Start Date: 27/Feb/20 08:14
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #10883:
[BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#discussion_r384969152
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/values/RowTest.java
##########
@@ -477,6 +477,172 @@ public void testCreateMapWithRowValue() {
assertEquals(data, row.getMap("map"));
}
+ @Test
Review comment:
I propose to take this discussion out of this PR, as I really like this
already. For me it's already a LGTM. (Best to wait till the 2.20 is cut though).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 394021)
Time Spent: 3.5h (was: 3h 20m)
> The Row object needs better builders
> ------------------------------------
>
> Key: BEAM-9331
> URL: https://issues.apache.org/jira/browse/BEAM-9331
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Users should be able to build a Row object by specifying field names. Desired
> syntax:
>
> Row.withSchema(schema)
> .withFieldName("field1", "value)
> .withFieldName("field2.field3", value)
> .build()
>
> Users should also have a builder that allows taking an existing row and
> changing specific fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
