[
https://issues.apache.org/jira/browse/BEAM-8078?focusedWorklogId=394436&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394436
]
ASF GitHub Bot logged work on BEAM-8078:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/20 20:06
Start Date: 27/Feb/20 20:06
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #10914: [BEAM-8078]
streaming_wordcount_debugging.py is missing a test
URL: https://github.com/apache/beam/pull/10914#discussion_r385343245
##########
File path: sdks/python/apache_beam/examples/streaming_wordcount_debugging.py
##########
@@ -71,16 +72,14 @@ def process(
class AddTimestampFn(beam.DoFn):
"""A DoFn that attaches timestamps to its elements.
- It takes a string of integers and it attaches to each of them
- a timestamp of its same value.
+ It just takes an element and adds a current timestamp.
- For example, [120, 225, 312] will result in:
- [(120, Timestamp(120)), (225, Timestamp(225)), (312, Timestamp(312))].
+ For example, Sometext will result in:
+ (Sometext, Timestamp(1234567890).
Review comment:
That will be better by making tests reproducible. That will result in
elements with timestamps across a wide range. Testers would not be able to
predict what element will be in which window.
we change the input to be a tuple <message>,<timestamp> with a comma
separation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 394436)
Time Spent: 1h 20m (was: 1h 10m)
> streaming_wordcount_debugging.py is missing a test
> --------------------------------------------------
>
> Key: BEAM-8078
> URL: https://issues.apache.org/jira/browse/BEAM-8078
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Aleksey Vysotin
> Priority: Minor
> Labels: beginner, easy, newbie, starter
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It's example code and should have a basic_test (like the other wordcount
> variants in [1]) to at least verify that it runs in the latest Beam release.
> [1]
> https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
