[ https://issues.apache.org/jira/browse/BEAM-9300?focusedWorklogId=394489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394489 ]
ASF GitHub Bot logged work on BEAM-9300: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/Feb/20 22:00 Start Date: 27/Feb/20 22:00 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10967: [BEAM-9300] convert struct literal in ZetaSQL URL: https://github.com/apache/beam/pull/10967#discussion_r385396445 ########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamBigQuerySqlDialect.java ########## @@ -222,6 +222,14 @@ public void unparseCall( } writer.endFunCall(frame); break; + case ROW: Review comment: I thought about replacing [`SqlRowOperator`](https://calcite.apache.org/apidocs/org/apache/calcite/sql/fun/SqlRowOperator.html) with our own custom operator. But I like this better, because it only overrides unparsing without affecting the rest of the operator code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 394489) Time Spent: 1h 10m (was: 1h) > parse struct literal in ZetaSQL > ------------------------------- > > Key: BEAM-9300 > URL: https://issues.apache.org/jira/browse/BEAM-9300 > Project: Beam > Issue Type: New Feature > Components: dsl-sql-zetasql > Reporter: Kyle Weaver > Assignee: Kyle Weaver > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L569 -- This message was sent by Atlassian Jira (v8.3.4#803005)