[
https://issues.apache.org/jira/browse/BEAM-8542?focusedWorklogId=394811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-394811
]
ASF GitHub Bot logged work on BEAM-8542:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/20 10:32
Start Date: 28/Feb/20 10:32
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #10078: [BEAM-8542]
Change write to async in AWS SNS IO & remove retry logic
URL: https://github.com/apache/beam/pull/10078#issuecomment-592054114
@Akshay-Iyangar Thank you for taking care of this! Could you exclude a
commit that merges master into feature branch and use rebase instead? Also,
please squash all *your* commits but keep Ajo Thomas commit as well (to respect
all creds). And finally, please, format all commits with the following pattern
- "[BEAM-8542] Commit message" (see [Contribution
Guide](https://beam.apache.org/contribute/#make-your-change))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 394811)
Time Spent: 5.5h (was: 5h 20m)
> Add async write to AWS SNS IO & remove retry logic
> --------------------------------------------------
>
> Key: BEAM-8542
> URL: https://issues.apache.org/jira/browse/BEAM-8542
> Project: Beam
> Issue Type: Improvement
> Components: io-java-aws
> Reporter: Ajo Thomas
> Assignee: Ajo Thomas
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> - While working with SNS IO for one of my work-related projects, I found that
> the IO uses synchronous publishes during writes. I had a simple mock pipeline
> where I was reading from a kinesis stream and publishing it to SNS using
> Beam's SNS IO. For comparison, I also had a lamdba which did the same using
> asynchronous publishes but was about 5x faster. Changing the SNS IO to use
> async publishes would improve publish latencies.
> - SNS IO also has some retry logic which isn't required as SNS clients can
> handle retries. The retry logic in the SNS client is user-configurable and
> therefore, an explicit retry logic in SNS IO is not required
> I have a working version of the IO with these changes, will create a PR
> linking this ticket to it once I get some feedback here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
