[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=396645&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396645
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/20 05:45
Start Date: 03/Mar/20 05:45
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #11022: [BEAM-7746]
Resolve typing issues in filesystem
URL: https://github.com/apache/beam/pull/11022#discussion_r386809980
##########
File path: sdks/python/apache_beam/io/localfilesystem.py
##########
@@ -136,10 +137,17 @@ def _path_open(
mode,
mime_type='application/octet-stream',
compression_type=CompressionTypes.AUTO):
+ # type: (...) -> BinaryIO
+
"""Helper functions to open a file in the provided mode.
"""
compression_type = FileSystem._get_compression_type(path, compression_type)
- raw_file = open(path, mode)
+ if mode == 'r':
+ mode = 'rb'
+ elif mode == 'w':
+ mode = 'wb'
Review comment:
I saw this pattern in another filesystem so I thought I'd add it here to
make it completely obvious that the subsequent cast to `BinaryIO` (from
`IO[Any]`) is safe and warranted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 396645)
Time Spent: 70h (was: 69h 50m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 70h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
