[
https://issues.apache.org/jira/browse/BEAM-9305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050025#comment-17050025
]
Elias Djurfeldt edited comment on BEAM-9305 at 3/3/20 9:00 AM:
---------------------------------------------------------------
Hi [~pabloem]! Thanks for the detailed information!
I've spent some time looking at the code and to me it looks like it won't be a
very big change. Basically all that needs to be done is something akin to what
the Datastore Query type does here:
[https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/datastore/v1new/types.py#L96-L99]
If that's true, then perhaps we can just pass along the query string as is
currently, in the *args, to _CustomBigQuerySource, which can then evaluate the
query like so:
{code:java}
if isinstance(query, ValueProvider):
self.query = query.get(){code}
[https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery.py#L625
]
But something tells me this is too easy to be true :)
was (Author: eliasdjur):
Hi [~pabloem]! Thanks for the detailed information!
I've spent some time looking at the code and to me it looks like it won't be a
very big change. Basically all that needs to be done is something akin to what
the Datastore Query type does here:
[https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/datastore/v1new/types.py#L96-L99]
If that's true, then perhaps we can just pass along the query string as is
currently, in the *args, to _CustomBigQuerySource, which can then evaluate the
query like so:
{code:java}
if isinstance(query, ValueProvider):
self.query = query.get(){code}
[https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery.py#L625]
> Support ValueProvider for BigQuerySource query string
> -----------------------------------------------------
>
> Key: BEAM-9305
> URL: https://issues.apache.org/jira/browse/BEAM-9305
> Project: Beam
> Issue Type: New Feature
> Components: io-py-gcp
> Reporter: Elias Djurfeldt
> Assignee: Elias Djurfeldt
> Priority: Minor
>
> Users should be able to use ValueProviders for the query string in
> BigQuerySource.
> Ref:
> [https://stackoverflow.com/questions/60146887/expected-eta-to-avail-pipeline-i-o-and-runtime-parameters-in-apache-beam-gcp-dat/60170614?noredirect=1#comment106464448_60170614]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
